fix NO_VERIFY_OID build in GetOID#10440
Open
JeremiahM37 wants to merge 2 commits intowolfSSL:masterfrom
Open
Conversation
dgarske
requested changes
May 8, 2026
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Please add an os-check for the NO_VERIFY_OID in the build matrix. Our CI should have caught this.
Contributor
Author
Done |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move
actualOidandactualOidSzdeclarations out of the#ifndef NO_VERIFY_OIDblock inGetOID()and drop the assignment guard. They're used unconditionally bywc_oid_sum()(added in 1123516), so gating the declarations onNO_VERIFY_OIDbroke compilation.NO_VERIFY_OID + WOLFSSL_FPKIwas broken for the same reason.Fixes #10423
Credit
Thanks to @cpsource for the proposed patch
Testing
Pre-patch with
-DNO_VERIFY_OID: reproduces reporter's compile error.Post-patch with
-DNO_VERIFY_OID,-DNO_VERIFY_OID -DWOLFSSL_FPKI, and default: all build clean.make checkpasses.